Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] #3714: Signature validation in no_std #4270

Merged
merged 1 commit into from
Feb 12, 2024
Merged

[feature] #3714: Signature validation in no_std #4270

merged 1 commit into from
Feb 12, 2024
+4 −27

Conversation

Arjentix
Copy link
Contributor

@Arjentix Arjentix commented Feb 8, 2024

Description

  • Revised all no_std constructions in data_model.
  • Also did that for other crates, but there was nothing to change.

Linked issue

Benefits

  • Signature verification in no_std environment

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@Arjentix Arjentix added Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Feb 8, 2024
@Arjentix Arjentix self-assigned this Feb 8, 2024
@Arjentix Arjentix force-pushed the no_std_query_validation branch 3 times, most recently from 95cc9bf to 60fc5f1 Compare February 8, 2024 18:46
Arjentix
Arjentix commented Feb 8, 2024
View reviewed changes
configs/peer/genesis.json Outdated Show resolved Hide resolved
@Arjentix
[feature] hyperledger#3714: Signature validation in no_std
533e05f 
Signed-off-by: Daniil Polyakov <arjentix@gmail.com>
@mversic mversic merged commit 8b40e88 into hyperledger:iroha2-dev Feb 12, 2024
11 checks passed
@Arjentix Arjentix deleted the no_std_query_validation branch February 12, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erigara Erigara Erigara approved these changes

@mversic mversic mversic approved these changes

@s8sato s8sato Awaiting requested review from s8sato

@SamHSmith SamHSmith Awaiting requested review from SamHSmith

@QuentinI QuentinI Awaiting requested review from QuentinI

@outoftardis outoftardis Awaiting requested review from outoftardis

@ilchu ilchu Awaiting requested review from ilchu

@pesterev pesterev Awaiting requested review from pesterev

@0x009922 0x009922 Awaiting requested review from 0x009922

@DCNick3 DCNick3 Awaiting requested review from DCNick3

Assignees

@Arjentix Arjentix

Labels
Enhancement New feature or request iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arjentix @Erigara @mversic